Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JBake 2.7.0-rc.6 #70

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msgilligan
Copy link

@msgilligan msgilligan commented Nov 30, 2022

This builds on macOS with Apple Silicon.

Also updated related dependencies

Notes:

  1. Hard-coded resolutionStrategy versions in build.gradle
  2. Hard-coded rc.6 release of JBake 2.7.0

Also updated related dependencies

Notes:

1. Hard-coded resolutionStrategy versions in build.gradle
2. Hard-coded rc.6 release of JBake 2.7.0
@msgilligan msgilligan marked this pull request as draft November 30, 2022 04:22
Copy link
Author

@msgilligan msgilligan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review gives some reasons why this is a draft PR>

resolutionStrategy {
force "com.github.jnr:jnr-posix:3.1.15"
force "com.github.jnr:jnr-constants:0.10.3"
force "com.github.jnr:jffi:1.3.9"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-coded version numbers here are one reason why this is a DRAFT PR.

commonsIoVersion = 2.8.0
jbakeVersion = 2.6.7
commonsIoVersion = 2.11.0
jbakeVersion = 2.7.0-rc.6
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-rc.6 here is another reason this is a DRAFT PR

@@ -32,7 +32,7 @@ class JbakeIntegrationSpec extends PluginIntegrationSpec {
String latestGradleVersion = '7.0.2'

@Shared
String latestJbakeVersion = '2.6.7'
String latestJbakeVersion = '2.7.0-rc.6'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-rc.6 here is another reason this is a DRAFT PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant