Skip to content

renderbug: allow events without element#23

Open
coderofsalvation wants to merge 1 commit into
jbaicoianu:masterfrom
coderofsalvation:bugfix/event-without-element
Open

renderbug: allow events without element#23
coderofsalvation wants to merge 1 commit into
jbaicoianu:masterfrom
coderofsalvation:bugfix/event-without-element

Conversation

@coderofsalvation
Copy link
Copy Markdown
Contributor

@coderofsalvation coderofsalvation commented Apr 16, 2026

The event system allows for generic events (like firing something without an element-value e.g.).
This is great, because that allows assetscripts to fire stuff without passing an element.
But...render.js chokes on it (sometimes every frame when listening to frame events).
This fix prevents hogging the console with errors (of not being able to read .parent from null)

I have a hunch that due to the lazy initializations of elements in janusweb, element sometimes also might be null for small amounts of time. I'm saying this because I'm stresstesting loading 5 nested heavy janus-rooms simultaniously (vesta + janusxr lobby + etc ) via <link url="..." url_pos="0 0 0" auto_load="true" />, so this might be a good discover 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant