Fix: ensure stroke is applied to all lines in multiline text with emojis

[Scr44gr]

In the original implementation, there was logic that set stroke_width to 0 during the text rendering process in the getmask2 function call. This caused subsequent lines of text to lose their stroke, as the stroke width was effectively disabled after the first line.

The fix involved removing the part where stroke_width was set to 0 after the stroke was applied. By doing this, the stroke_width parameter is preserved across all lines of the multiline text, ensuring that each line has its proper stroke.

Additionally, the stroke_width argument was removed from the getmask2 call. This ensures that the stroke is applied consistently throughout all iterations when rendering the text. Instead of resetting the stroke for each line, the value of stroke_width remains intact, allowing the stroke to be applied uniformly to each line of text, including those that come after the first line.

This change ensures that the stroke is not lost when processing multiple lines of text, which was the core issue when rendering multiline text with emojis.

Summary by Sourcery

Bug Fixes:

• Fix stroke application to ensure it is applied to all lines in multiline text with emojis by not setting stroke_width to 0.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes an issue with stroke application in multiline text containing emojis. The main change involves removing the reset of stroke_width to 0 and the passing of stroke_width to the getmask2 function.

Class diagram for changes in stroke application

classDiagram
    class Core {
        +getink(fill)
    }
    Core : -stroke_width
    Core : -getmask2(..., stroke_width, ...)
    note for Core "Removed stroke_width reset and its usage in getmask2"

Loading

File-Level Changes

Change	Details	Files
Remove stroke_width reset and parameter in text rendering	Remove the line that sets stroke_width to 0 Remove stroke_width parameter from getmask2 function call	pilmoji/core.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Scr44gr - I've reviewed your changes - here's some feedback:

Overall Comments:

• Have you tested this change with various types of text input, including those without emojis? Please ensure comprehensive testing to avoid unintended side effects.
• Consider improving the commit message to clearly explain the problem this change is solving and why it's necessary. This will help future maintainers understand the reasoning behind the modification.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}