Skip to content

Fix incorrect number of return values in docstring of embedding.preprocess_sparsecore_inputs. #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect number of return values in docstring of embedding.preprocess_sparsecore_inputs. #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jax_tpu_embedding/sparsecore/lib/nn/embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,8 +334,8 @@ def preprocess_sparse_dense_matmul_input(
the max_ids_per_partition or max_unique_ids_per_partition limits.

Returns:
A tuple of four dictionaries mapping the stacked table names to the
preprocessed inputs for the corresponding table. The four dictionaries are
A tuple of five dictionaries mapping the stacked table names to the
preprocessed inputs for the corresponding table. The five dictionaries are
lhs_row_pointers, lhs_embedding_ids, lhs_sample_ids, lhs_gains and stats.
"""
tree.assert_same_structure(features, feature_specs)
Expand Down