Draft
Conversation
|
Getting a panic. Pulled this branch: GO111MODULE=on go get github.com/jawher/mow.cli@issue-104-app-modelHere's a pared-down file that shows the issue: package main
import (
"os"
"github.com/davecgh/go-spew/spew"
cli "github.com/jawher/mow.cli"
)
func main() {
app := cli.App("myapp", "Description.")
app.Version("version", "1")
app.Command("do", "Do the thing.", func(config *cli.Cmd) {})
spew.Dump(app.Model())
err = app.Run(os.Args)
if err != nil {
exitErrorf(err)
}
}And the panic. I don't see anything obvious in the code other than |
Owner
Author
|
@skyzyx Nice catch ! I just pushed a commit to fix a bug in a slice allocation len 🤦♂️ |
3da148f to
519fe99
Compare
|
Had a chance to come back to this, and I'm quite happy with the results. THANK YOU! |
skyzyx
approved these changes
Nov 16, 2020
|
Ping |
|
This is available on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app.Model()Fixes #104