Create a new pull request by comparing changes across two branches #949

GulajavaMinistudio · 2023-12-08T07:27:56Z

No description provided.

Add a flag for each experimental feature to indicate its presence. That way, if we compile with `NAPI_EXPERIMENTAL` turned on, we'll be able to distinguish between what `NAPI_EXPERIMENTAL` used to mean on an old version of the headers when compiling against such an old version, and what it means on a new version of Node.js. PR-URL: #50991 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>

Refs: nodejs/performance#114 PR-URL: #50586 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>

PR-URL: #51069 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: #50994 Fixes: #50979 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Raz Luvaton <[email protected]> Reviewed-By: Robert Nagy <[email protected]>

PR-URL: #51063 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Raz Luvaton <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>

The optional `length` argument is supposed to determine the length of the AES-GCM key, so it may be 128, 192, or 256. PR-URL: #51066 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

gabrielschulhof and others added 6 commits December 6, 2023 12:08

benchmark: add undici websocket benchmark

212a972

Refs: nodejs/performance#114 PR-URL: #50586 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>

build: fix warnings from uv for gn build

3f4ea7a

PR-URL: #51069 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

stream: fix fd is null when calling clearBuffer

639c366

PR-URL: #50994 Fixes: #50979 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Raz Luvaton <[email protected]> Reviewed-By: Robert Nagy <[email protected]>

fs: update params in jsdoc for createReadStream and createWriteStream

42b238e

PR-URL: #51063 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Raz Luvaton <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>

GulajavaMinistudio merged commit a0b4e90 into javascript-indonesias:master Dec 8, 2023
20 of 21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a new pull request by comparing changes across two branches #949

Create a new pull request by comparing changes across two branches #949

GulajavaMinistudio commented Dec 8, 2023

Create a new pull request by comparing changes across two branches #949

Create a new pull request by comparing changes across two branches #949

Conversation

GulajavaMinistudio commented Dec 8, 2023