feat: support 'Hidden' and 'NoDisplay' keys#133
Open
kyriemeows wants to merge 1 commit into
Open
Conversation
Owner
|
Looks good! Will properly review, test and merge when I get a proper break from final exams. |
javalsai
reviewed
Jun 22, 2026
| char* NULLABLE name; | ||
| char* NULLABLE exec; | ||
| char* NULLABLE tryexec; | ||
| char* NULLABLE nodisplay; |
Owner
There was a problem hiding this comment.
If these are supposed to be booleans shouldn't we make this a boolean and parse the value with its key? We avoid heap overuse by copying "true"s around, and can forget about freeing it later.
Author
There was a problem hiding this comment.
Sounds good, I'll revise this in a bit.
|
|
||
| if (ctx->name != NULL && ctx->exec != NULL && ctx->tryexec != NULL) { | ||
| if (ctx->name != NULL && ctx->exec != NULL && ctx->tryexec != NULL && | ||
| ctx->nodisplay != NULL && ctx->hidden != NULL) { |
Owner
There was a problem hiding this comment.
If we use booleans instead, could make this something analogous to a rust's Option<bool> and just finish once its something. Otherwise it's just gonna close the file before reaching such keys if they are after the rest.
javalsai
requested changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.desktop entries with
Hidden=trueandNoDisplay=trueshould not appear in the selector.