streams HW #55
Open
streams HW #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senia-psm
reviewed
Apr 12, 2017
| } | ||
| List<Person> actual = employees.stream() | ||
| .filter(e -> e.getJobHistory().stream() | ||
| .map(JobHistoryEntry::getEmployer).anyMatch(employer -> employer.equals("epam"))) |
There was a problem hiding this comment.
Note that you could use .anyMatch("epam"::equals) instead.
| List<Person> expected = new ArrayList<>(); | ||
|
|
||
| for (Employee e : employees) { | ||
| if (e.getJobHistory().get(0).equals("epam")) |
There was a problem hiding this comment.
Don't use get - it throws an exception on empty collection.
| Map<String, List<Person>> employeesIndex = getEmployees().stream() | ||
| .map(e -> new PersonEmployerDuration( | ||
| e.getPerson(), | ||
| e.getJobHistory().get(0).getEmployer())) |
senia-psm
reviewed
Apr 13, 2017
| final Map<Key, List<Value>> keyValuesMap1 = valueMap1.entrySet().stream() | ||
| .collect(toMap(e -> keyMap1.get(e.getKey()), | ||
| Map.Entry::getValue, | ||
| (values, values2) -> { |
There was a problem hiding this comment.
You can't get collision here. no need in this parameter.
senia-psm
reviewed
Apr 13, 2017
|
|
||
| final Map<Key, List<Value>> keyValuesMap2 = valuesMap2 | ||
| .entrySet().stream() | ||
| .collect(toMap(e->keyMap2.get(e.getKey()), |
senia-psm
reviewed
Apr 18, 2017
| values.addAll(values2); | ||
| return values; | ||
| })); | ||
| Map.Entry::getValue)); |
There was a problem hiding this comment.
Actually you may need conflict resolver here for null keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.