Skip to content

Refactor the architecture. #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor the architecture. #1344

wants to merge 1 commit into from

Conversation

Ayush2395
Copy link

  • Added 2 interfaces IDomainEvent and IAuditableEntity in the Domain, I've putted this in common folder.
  • Change the Event from class to record.
  • In infrastructure class library, I've changed the interceptors with IDomainEvent and IAuditableEntity.
  • Added the IAuditableEntity and IDomainEvent in the ApplicationUser entity.
  • These changes helps to solve the complexity of project when it is scalling, that's I've experienced.
  • Move the ApplicationUser entity from Infrastructure to Domain.

@Ayush2395
- Move the ApplicationUser entity from Infrastructure to Domain.
72be8cc 
- Added 2 interfaces IDomainEvent and IAuditableEntity in the Domain, I've putted this in common folder.
- Change the Event from class to record.
- In infrastructure class library, I've changed the interceptors with IDomainEvent and IAuditableEntity.
- Added the IAuditableEntity and IDomainEvent in the ApplicationUser entity.
- These changes helps to solve the complexity of project when it is scalling, that's I've experienced.
@jasontaylordev
Copy link
Owner

jasontaylordev commented Jul 25, 2025 •
edited
Loading

Thanks for the contribution @Ayush2395 - there are some great changes here! Could you please update your branch with the latest main and resolve the conflicts so we can review it properly?

One note: I generally prefer not to make all entities auditable, so I’d rather have BaseAuditableEntity inherit from BaseEntity, not the other way around. Also, we can probably rename ApplicationUser to User.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ayush2395 @jasontaylordev