Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eve2pcap: use sid as name when available #319

Closed
wants to merge 1 commit into from

Conversation

victorjulien
Copy link
Contributor

@victorjulien victorjulien commented Dec 14, 2024

Tested locally in oneshot mode, appears to work correctly.

@victorjulien victorjulien marked this pull request as ready for review December 14, 2024 09:06
@jasonish
Copy link
Owner

Better for sure. Do you think there is anything else that should go in that filename?

@victorjulien
Copy link
Contributor Author

Better for sure. Do you think there is anything else that should go in that filename?

I guess in my workflow I would call something inliniac-public-sid-12345-dns-blah.pcap, so maybe at least the app proto? But an option that would present a text box could also work, but not sure how that would work here.

@jasonish
Copy link
Owner

Merged. Thanks!

@jasonish jasonish closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants