bug fixing for MPNetEntityInjector and run file #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear KAPING author,
While replicating your source code, I encountered the following bugs, which have been fixed in this pull request:
callfunction of MPNetEntityInjector, the type of thequestionis expected to be in list format, but a string format was input when using thecallfunction. I have adjusted the input inmodel.pyto be a list. Additionally, in theinjectionfunction ofMPNetEntityInjector, thequestionis expected to be a string, which has also been correspondingly adjusted.top_k_triple_extractorfunction ofMPNetEntityInjectorincorrectly outputted the triples embedding instead of the intended triples list. The reason is that the function only received the triples embedding as input. This has been fixed. Moreover, when the random flag is set to True, theinfosvariable does not exist. Based on my understanding of your paper, I have adjusted it totriples.run.py,evaluatedis a list, andevaluateis the assessment function. It seems you have confused the two in the source code.entity_verbalization.py, which has now been fixed.I hope you will accept this pull request to facilitate the replication of this paper in the future.