Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wrapper): add kubernetes-actions plugin wrapper #2085

Merged
merged 2 commits into from
Jan 3, 2025
Merged

chore(wrapper): add kubernetes-actions plugin wrapper #2085

merged 2 commits into from
Jan 3, 2025

Conversation

dzemanov
Copy link
Member

Description

Add plugin wrapper for:

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@dzemanov dzemanov requested a review from a team as a code owner December 10, 2024 09:53
@dzemanov dzemanov changed the title chore(wrapper): add kubernetes-actions plugin wrapper chore(wrapper): add kubernetes-actions plugin wrapper Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@dzemanov
Copy link
Member Author

/retest

1 similar comment
@dzemanov
Copy link
Member Author

/retest

@subhashkhileri
Copy link
Member

/test e2e-tests

@dzemanov
Copy link
Member Author

/retest

@dzemanov dzemanov force-pushed the add-kubernetes-actions branch from 9437006 to e776e14 Compare December 17, 2024 09:35
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@dzemanov dzemanov force-pushed the add-kubernetes-actions branch from e776e14 to f4791e4 Compare December 19, 2024 16:16
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

AndrienkoAleksandr
AndrienkoAleksandr approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine, k8s namespace was created in the cluster-bot instance.

Notice: my test scenario did not include a cluster entity in the catalog API.

@openshift-ci openshift-ci bot added the lgtm label Dec 20, 2024
@04kash 04kash mentioned this pull request Dec 22, 2024
Merged
5 tasks
@dzemanov
Copy link
Member Author

/assign @gustavolira for approval

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 23, 2024

@dzemanov: GitHub didn't allow me to assign the following users: for, approval.

Note that only janus-idp members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @gustavolira for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added approved and removed lgtm labels Dec 23, 2024
@dzemanov dzemanov force-pushed the add-kubernetes-actions branch from 1dd8c34 to d38bff6 Compare December 23, 2024 12:30
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@dzemanov
Copy link
Member Author

/retest

@dzemanov dzemanov force-pushed the add-kubernetes-actions branch from d38bff6 to 02a6e24 Compare December 23, 2024 14:30
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@dzemanov
Copy link
Member Author

/retest

@dzemanov dzemanov force-pushed the add-kubernetes-actions branch from 02a6e24 to ced2c6d Compare January 2, 2025 08:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

The image is available at:

@dzemanov dzemanov requested a review from gustavolira January 2, 2025 10:18
@dzemanov dzemanov force-pushed the add-kubernetes-actions branch from ced2c6d to de2160c Compare January 2, 2025 16:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

The image is available at:

@dzemanov
Introduce kubernetes-actions
5163ee1 
Signed-off-by: Dominika Zemanovicova <[email protected]>
@dzemanov
Fix order
3aa5511 
Signed-off-by: Dominika Zemanovicova <[email protected]>
@dzemanov dzemanov force-pushed the add-kubernetes-actions branch from de2160c to 3aa5511 Compare January 3, 2025 11:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

The image is available at:

@dzemanov
Copy link
Member Author

dzemanov commented Jan 3, 2025

/retest

04kash
04kash approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@04kash 04kash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 3, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 04kash, AndrienkoAleksandr, gustavolira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e9ac517 into janus-idp:main Jan 3, 2025
10 checks passed
@dzemanov dzemanov deleted the add-kubernetes-actions branch January 3, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@04kash 04kash 04kash approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@albarbaro albarbaro Awaiting requested review from albarbaro

@its-mitesh-kumar its-mitesh-kumar Awaiting requested review from its-mitesh-kumar

@gustavolira gustavolira Awaiting requested review from gustavolira

Assignees

@gustavolira gustavolira

@AndrienkoAleksandr AndrienkoAleksandr

@04kash 04kash

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dzemanov @subhashkhileri @gustavolira @AndrienkoAleksandr @04kash