Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): switch to rhdh-plugins theme which also incl. some mui v5 fixes #2033

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Dec 1, 2024

Description

This PR switch the theme from https://github.com/redhat-developer/red-hat-developer-hub-theme repo to https://github.com/redhat-developer/rhdh-plugins/tree/main/workspaces/theme

The npm version 0.4.0 of both packages was the same, but the latest 0.4.x already contains some MUI v5 bugfixes.

https://github.com/redhat-developer/rhdh-plugins/blob/main/workspaces/theme/plugins/theme/CHANGELOG.md

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Dec 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

github-actions bot commented Dec 1, 2024

Copy link
Contributor

github-actions bot commented Dec 2, 2024

@christoph-jerolimov christoph-jerolimov changed the title fix(theme): fix mui v5 paper background color fix(theme): migrate to rhdh-plugins and fix mui v5 issues (WIP) Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

@christoph-jerolimov christoph-jerolimov changed the title fix(theme): migrate to rhdh-plugins and fix mui v5 issues (WIP) fix(theme): switch to rhdh-plugins theme with same first mui v5 fixes Dec 5, 2024
@christoph-jerolimov christoph-jerolimov marked this pull request as ready for review December 5, 2024 03:12
@christoph-jerolimov christoph-jerolimov requested a review from a team as a code owner December 5, 2024 03:12
Copy link
Contributor

github-actions bot commented Dec 5, 2024

@christoph-jerolimov
Copy link
Member Author

Font is missing...

/hold

@christoph-jerolimov christoph-jerolimov changed the title fix(theme): switch to rhdh-plugins theme with same first mui v5 fixes fix(theme): switch to rhdh-plugins theme which also incl. some mui v5 fixes Dec 6, 2024
@christoph-jerolimov christoph-jerolimov force-pushed the update-theme branch 2 times, most recently from d9b0ad0 to a3ab99a Compare December 6, 2024 11:12
Copy link
Contributor

github-actions bot commented Dec 6, 2024

@its-mitesh-kumar
Copy link

/lgtm for bulk import

Screen.Recording.2024-12-06.at.6.20.42.PM.mov

@christoph-jerolimov
Copy link
Member Author

Test with pr-2033-5a56eeac:

I noticed a lot of small improvements with background colors, but also some blocking issues.

Fixes

Description Before With this PR 1.3
Bulk import Add repository page uses same background color for card and table Screenshot From 2024-12-06 13-37-27 image image
Bulk import Add repo drawer background color image Screenshot From 2024-12-06 13-41-30 Screenshot From 2024-12-06 13-41-44
RBAC sidebar with changed background color and outline around buttons image image image
Card borders are back and vertical tab selection-indicator is now on the right side Screenshot From 2024-12-06 13-47-53 image image

Issues

Description Before With this PR 1.3
The Red Hat font is still missing no picture no picture no picture
The biggest difference is the missing padding around the tables, but I need to check this with @ShiranHi and maybe @ciiay if they are mandatory. I'm fine with reverting that change for now. Screenshot From 2024-12-06 13-31-16 Screenshot From 2024-12-06 13-30-31 no picture
Missing padding in bulk import (MUI v5) image Screenshot From 2024-12-06 13-34-55 no picture
Missing padding on search, also the search bar misses background color since 1.4 Screenshot From 2024-12-06 13-54-01 image Screenshot From 2024-12-06 13-54-33
Missing shadow or border around action dropdown image image Screenshot From 2024-12-06 13-58-18

@its-mitesh-kumar
Copy link

tested topology .

Screen.Recording.2024-12-06.at.6.34.23.PM.mov

@its-mitesh-kumar
Copy link

Tested with pr-2033 , image pr-2033 will contain changes from latest commit , right @christoph-jerolimov ?

Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: its-mitesh-kumar
Once this PR has been reviewed and has the lgtm label, please ask for approval from christoph-jerolimov. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Copy link
Contributor

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants