-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): switch to rhdh-plugins theme which also incl. some mui v5 fixes #2033
base: main
Are you sure you want to change the base?
fix(theme): switch to rhdh-plugins theme which also incl. some mui v5 fixes #2033
Conversation
Skipping CI for Draft Pull Request. |
The image is available at: |
31e6bba
to
f361bc4
Compare
The image is available at: |
65ff69e
to
fc1f4ea
Compare
The image is available at: |
fc1f4ea
to
caa3d0a
Compare
The image is available at: |
Font is missing... /hold |
caa3d0a
to
0c19fd1
Compare
d9b0ad0
to
a3ab99a
Compare
a3ab99a
to
5a56eea
Compare
The image is available at: |
/lgtm for bulk import Screen.Recording.2024-12-06.at.6.20.42.PM.mov |
Test with pr-2033-5a56eeac: I noticed a lot of small improvements with background colors, but also some blocking issues. FixesIssues
|
tested topology . Screen.Recording.2024-12-06.at.6.34.23.PM.mov |
Tested with pr-2033 , image pr-2033 will contain changes from latest commit , right @christoph-jerolimov ? |
5a56eea
to
4ee15f2
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: its-mitesh-kumar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The image is available at: |
…ui v5 fixes Signed-off-by: Christoph Jerolimov <[email protected]>
4ee15f2
to
0c793a5
Compare
The image is available at: |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
This PR switch the theme from https://github.com/redhat-developer/red-hat-developer-hub-theme repo to https://github.com/redhat-developer/rhdh-plugins/tree/main/workspaces/theme
The npm version 0.4.0 of both packages was the same, but the latest 0.4.x already contains some MUI v5 bugfixes.
https://github.com/redhat-developer/rhdh-plugins/blob/main/workspaces/theme/plugins/theme/CHANGELOG.md
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer