Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift auth provider POC [DO NOT MERGE] #1538

Closed
wants to merge 2 commits into from

Conversation

Zaperex
Copy link
Member

@Zaperex Zaperex commented Aug 28, 2024

Description

Just an initial POC of an openshift auth provider. Half of the requests still go through the backstage instance, so the TLS configurations won't exactly work. Logout is currently disabled since it seems the route handler does not pass in the accessToken to the logout function, and only passes in a refreshToken instead which this auth provider does not provide.

Please note that there's no entity provider to ingest the users that are expected by this auth provider, so manual ingestion may be necessary to test.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Aug 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zaperex. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Zaperex Zaperex changed the title openshift auth provider POC openshift auth provider POC [DO NOT MERGE] Aug 28, 2024
Copy link

sonarcloud bot commented Aug 28, 2024

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@schultzp2020
Copy link
Member

Stale, please reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants