Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): can we move up to node20 in... #1550

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

nickboldt
Copy link
Member

What does this PR do?

chore(deps): can we move up to node20 in .nvmrc ? this would allow using semantic-release 10 (currently using 9): #1475

Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…ing semantic-release 10 (currently using 9): #1475

Signed-off-by: Nick Boldt <[email protected]>
@nickboldt nickboldt requested a review from a team as a code owner April 25, 2024 19:12
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BethGriggs, schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt merged commit a706254 into main Apr 25, 2024
11 of 12 checks passed
@nickboldt nickboldt deleted the bump-nvmrc-to-20 branch April 25, 2024 19:21
ciiay pushed a commit to ciiay/backstage-plugins that referenced this pull request Jun 1, 2024
chore(deps): can we move up to node20 in .nvmrc ? this would allow using semantic-release 10 (currently using 9): janus-idp#1475

Signed-off-by: Nick Boldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants