Skip to content

Add tests for reduce #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Add tests for reduce #81

merged 2 commits into from
Mar 31, 2025

Conversation

cddr
Copy link
Contributor

@cddr cddr commented Mar 8, 2025

Add tests for:

  • reduce

@CLAassistant
Copy link

CLAassistant commented Mar 8, 2025

CLA assistant check
All committers have signed the CLA.

@frenchy64
Copy link
Contributor

There's a few more edge cases documented in the reduce docstring if you're interested. Also reduced.

@jeaye
Copy link
Member

jeaye commented Mar 19, 2025

Thanks for the PR, Andy! reduced is its own var, so that should go into its own file. We don't need to worry about it for this PR. @cddr are you interested in expanding on this for the edge cases which @frenchy64 mentioned?

@cddr
Copy link
Contributor Author

cddr commented Mar 28, 2025

Ah sorry, notifications were not getting through. Yeah I'll do those this weekend.

@jeaye
Copy link
Member

jeaye commented Mar 31, 2025

Thanks! Have you added everything you'd like to add, at this point?

@cddr
Copy link
Contributor Author

cddr commented Mar 31, 2025

For reduce yes. Might do some other functions in the future.

@jeaye jeaye merged commit 6948f6a into jank-lang:main Mar 31, 2025
1 check passed
@jeaye
Copy link
Member

jeaye commented Mar 31, 2025

Sounds great. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants