Fix bad :default min value
#760
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeaye
reviewed
Sep 21, 2025
| :cljr Int64/MinValue | ||
| :cljs js/Number.MIN_SAFE_INTEGER | ||
| :default 0x8000000000000000)) | ||
| :default -0x8000000000000000)) |
There was a problem hiding this comment.
On which host was this failing? bb? Every other host we support is covered above.
There was a problem hiding this comment.
I saw the issue initially in jank, but it also failed for clj when I switched it to use :default as well.
There was a problem hiding this comment.
I think we should remove this constant. It's all sorts of weird. We should just add a :jank branch which does (cpp/value "std::numeric_limits<jtl::i64>::min()").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing for me in jank and I think this test value is incorrect.