-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some clojure.string tests #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look great. bb changes, too. Can you please add some negative tests, and edge-case tests, though? i.e. what happens when:
- Input is nil
- Input is not a string
- Input is already capitalized
Try to break it and capture its behavior in tests.
…ite into clojure-string
Is this ready for review again? Trying to clean up the dozen PRs we have open. |
Yes I think so. |
Looks good! Thanks, Ambrose. |
Also included
subs
.