Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some clojure.string tests #70

Merged
merged 52 commits into from
Mar 19, 2025
Merged

Some clojure.string tests #70

merged 52 commits into from
Mar 19, 2025

Conversation

frenchy64
Copy link
Contributor

@frenchy64 frenchy64 commented Feb 6, 2025

Also included subs.

@frenchy64 frenchy64 marked this pull request as ready for review February 6, 2025 05:30
@frenchy64 frenchy64 changed the title WIP: clojure.string Some clojure.string tests Feb 6, 2025
Copy link
Member

@jeaye jeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look great. bb changes, too. Can you please add some negative tests, and edge-case tests, though? i.e. what happens when:

  • Input is nil
  • Input is not a string
  • Input is already capitalized

Try to break it and capture its behavior in tests.

@frenchy64 frenchy64 requested a review from jeaye February 24, 2025 22:34
@jeaye
Copy link
Member

jeaye commented Mar 19, 2025

Is this ready for review again? Trying to clean up the dozen PRs we have open.

@frenchy64
Copy link
Contributor Author

Yes I think so.

@jeaye jeaye merged commit 59e24a1 into jank-lang:main Mar 19, 2025
3 checks passed
@jeaye
Copy link
Member

jeaye commented Mar 19, 2025

Looks good! Thanks, Ambrose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants