Skip to content

Conversation

@mgrandrath
Copy link

I think this solves the race condition with socket.io. I basically did two things:

  • Make createSocket asynchronous so that it ensures that the new socket is actually connected. This made the tests a lot more stable.
  • Set a timeout for the underlying HTTP server. After removing all the other code the HTTP server did not shut down reliably. After poking around using getConnections() I found that occasionally there is a connection hanging there, preventing done() to be called. I resolved this by setting a timeout on the HTTP server to forcefully shut down all hanging connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant