Fix uncaught error from yield without arguments #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 big fan of this project! makes the migration to
typed-redux-saga
much simpler :)I did notice a minor bug - looks like yield expressions without arguments (i.e. just
yield;
) cause a crash due to the following section:eslint-plugin-typed-redux-saga/lib/rules/delegate-effects.js
Lines 40 to 43 in 2998c4a
With no arguments,
node.argument
isnull
whichisSagaCall
isn't able to handle.I've added a tiny check to just return
false
for that case since it's clearly not a saga call, though the defensive logic could be moved to consumers ofisSagaCall
as well.