Update gizmo crate to transform_gizmo_bevy to update egui version
#106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but a bit buggy
accidentally committed changes
and added documentation here and there
| pub camera_gizmo_active: bool, | ||
| pub gizmo_mode: GizmoMode, | ||
| /// Synced with the [transform_gizmo_bevy::GizmoOptions] resource | ||
| pub gizmo_modes: EnumSet<GizmoMode>, |
Contributor
Author
There was a problem hiding this comment.
The only breaking change, at least that I can see
Contributor
Author
|
Could we get this merged @jakobhellermann |
to avoid panics
5 tasks
Owner
|
Hi, I kinda missed this PR, sorry. I'll merge it together with #110 when the required dependencies are updated |
Owner
|
merged in #110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK this looks completed and polished to me, can somebody review and merge this? Ideally then a publish to crates.io using the latest Cargo.toml / dependencies would be greatly appreciated (see issue #105)
Technically this is a breaking change, since one field of the
GizmoStatestruct (used for the state of theEditorWindowtrait implementation) changed types fromegui-gizmo::GizmoModetoEnumSet<transform_gizmo_bevy::GizmoMode, although I doubt anybody was actually depending on this and hence I think a patch release to 0.8.2 is OKSo far this updates
egui-gizmowithtransform-gizmo-bevy, which is the new version of the old crate and which internally uses the newest version ofegui(0.27). It implements the hotkeys mapping (although there is a builtin hotkey system intransform-gizmo-bevyanyway), and mimics the old behaviour of starting out with translate only gizmos.