Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mintime similar to maxtime #1413

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

PetteriM1
Copy link

This pull request...

  • Fixes a bug
  • Introduces a new feature
  • Improves an existing feature
  • Boosts code quality or performance

Description

This pull request adds a config option "mintime" which works as the opposite of existing "maxtime".

Purpose

Not sure if anyone else will find this useful but I use this myself to limit the amount of short spam videos people attempt to play.

Copy link
Collaborator

@MichailiK MichailiK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation/code-wise, this looks good! I believe we will add this to JMusicBot once @jagrosh has a look at this.

Just one minor nitpick:

Comment on lines +1 to +8
/target/
/Playlists/
/test/
*.json
*.txt
nb*.xml
.idea
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be ideal to not change the .gitignore, as it sorta falls out of scope for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants