Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist user from using music and DJ commands #1367

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mnasiatka
Copy link

This pull request...

  • Fixes a bug
  • Introduces a new feature
  • Improves an existing feature
  • Boosts code quality or performance

Description

Adds command to blacklist a user from using music and DJ commands
!blacklist <user> - adds or removes user from blacklist
!blacklist none - clear all users from blacklist

Purpose

I have a user in my discord who keeps using !stop and I can't blacklist them. I have to have the dj role as the normal member role as I would like users to be able to control the volume.

This allows the admin to continue having all members as DJs while allowing them to prevent certain users from abusing music controls

Relevant Issue(s)

This PR closes issue #1322

@mnasiatka mnasiatka changed the title Blacklist Blacklist user from using music and DJ commands May 2, 2023
}
else if(found.size()>1)
{
StringBuilder builder = new StringBuilder();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with StringBuilder instead of OrderedMenu.Builder to display duplicates because it seems like any user would be able to interact with the emoji options and blacklist the incorrect user, which is not the intended use case. If OrderedMenu.Builder checks that the author is the one choosing the option I think it'd be fine to switch back to it though

@mnasiatka mnasiatka marked this pull request as ready for review May 2, 2023 17:08
@userzfr
Copy link

userzfr commented Jul 31, 2023

its a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants