Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Upgrade #486

Open
wants to merge 326 commits into
base: master
Choose a base branch
from
Open

Conversation

daniel-lewis-ab
Copy link

Changes:

npm audit passes
passes jest still
passes eslint (14,000+ fixes) on current settings
switched to jsdocs from yuidocs
switched to eslint from prettier
set up uglify to do compression when wanted to produce minified results
build script can tick up semantic versioning
pulled non-breaking PR fixes to Javi's repo
HTML now meets v4.01
CSS now valid
Fewer bad width/font error messages
Excised any reference to jQuery

**Currently throwing for SillyClient.js preventing call-home**
Javi, you may want your branch in particular to not have this change.  It's single line and an easy back-patch.

Not Changed:

Still using ES5, should be compatible with existing code
Still using CommonJS rather than modules, should be compatible with existing code
Typescript definitions should still be exactly intact
API should be exactly intact
Objective for this PR is a non-breaking pull. 🤞

Objective:

To let folks downstream take advantage of aforementioned changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants