Skip to content

Conversation

@billmwong
Copy link
Collaborator

@billmwong billmwong commented Mar 31, 2017

Homework Rubric: 36/50 total

Nice job on the things you completed! Don't merge this pull request, feel free to close it when you're done.

Functionality: 20/30

Completion: 10/20.

  • 10 - Some of the required features were implemented. Missing editing an item and filtering by active/completed.

Bug free: 10/10

  • 10 - The app is bug free.

Quality: 16/20

See my code comments!

Good coding practices: 7/10

  • 10 - Follow good naming conventions, use triple equals, use indents and whitespace where appropriate, know when to use global or local variables, etc.
  • 5 - Some of the above practices were broken, but you mostly followed good practices.

Readability: 9/10

  • 10 - Functions and variables are named well. Code is well commented where appropriate. Confusing lines are commented. Lines are not too long.
  • 5 - Code is occasionally confusing. Could use more comments. Some variables are poorly named.

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants