Skip to content

Catapp 1 feedback #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrennaManning wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Catapp 1 feedback #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50daf93
cat app feedback
Mar 28, 2017
82b1855
Update feedback.txt
Mar 28, 2017
110e50b
Update cats.handlebars
Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions homework2/feedback.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@

**Homework Feedback for Cat App**


Functionality:

All tasks completed! Awesome job, and your app appears to be bug free.

Completion: (20/20)

Bug Free: (10/10)


Quality:

Your code was well organized and commented! It was very clear and readable.
You followed good coding practices throughout!

Good Coding Practices: (10/10)

Readability: (10/10)


Summary:
It was very sad when the cats were murdered, but great job on this homework! Everything is functional and well written. You seem to have had a great understanding of how everything fits together. (50/50).
4 changes: 4 additions & 0 deletions homework2/routes/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,7 @@ module.exports.createCat = createCat;
module.exports.listCats = listCats;
module.exports.deleteCat = deleteCat;
module.exports.sortCats = sortCats;



// Great use of sort functions! Your code is clear, well commented, and readable!
3 changes: 3 additions & 0 deletions homework2/views/cats.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,6 @@
{{#if deleted}}
<p>{{deleted.name}} age {{deleted.age}} was murdered</p>
{{/if}}


{{!-- {{ This templating was nice! Keeping everything in a table was good visually.}} --}}