-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade all dependencies by regenerating lockfile #2470
Upgrade all dependencies by regenerating lockfile #2470
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2470 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 254 254
Lines 7679 7679
Branches 1931 1995 +64
=======================================
Hits 7419 7419
Misses 260 260 ☔ View full report in Codecov by Sentry. |
@@ -30,7 +30,8 @@ | |||
}, | |||
"resolutions": { | |||
"**/lodash": "^4.17.21", | |||
"rollup": "^4.13.1" | |||
"rollup": "^4.13.1", | |||
"cheerio": "1.0.0-rc.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -26,7 +26,6 @@ | |||
"@types/react-router-dom": "^5.1.0", | |||
"@types/redux-actions": "2.2.1", | |||
"@types/object-hash": "^3.0.2", | |||
"@types/rollup-plugin-visualizer": "^4.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest version of rollup-plugin-visualizer
is written in typescript, therefore types are not required anymore
@@ -80,7 +79,7 @@ | |||
"react-redux": "^8.1.2", | |||
"react-router-dom": "5.3.4", | |||
"react-router-dom-v5-compat": "^6.24.0", | |||
"react-vis": "^1.7.2", | |||
"react-vis": "1.11.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.11.12 is the current version in Jaeger UI, and the latest has some issues (see uber/react-vis#1485 (comment))
646d9dd
to
1abcb35
Compare
Signed-off-by: Andreas Gerstmayr <[email protected]>
1abcb35
to
7eb9f63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Which problem is this PR solving?
Description of the changes
To not regress, I created a small script to compare the old and new version of the lockfile:
Dependency dashboard (excluding equal, upgraded)
Summary: 343 upgraded, 1 downgraded, 11 added, 12 removed, 862 equal.
Full list of changes
Dependency dashboard
Summary: 343 upgraded, 1 downgraded, 11 added, 12 removed, 862 equal.
How was this change tested?
docker-compose -f ~/redhat/dev/jaeger/docker-compose/monitor/docker-compose.yml up -d
yarn start
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test