Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update LoadingIndicator component #2460

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ghaby-X
Copy link

@Ghaby-X Ghaby-X commented Sep 28, 2024

Which problem is this PR solving?

This PR aims to ensure compatibility of the LoadingIndicator component with future React releases. The LoadingIndicator component was using the older defaultProps syntax, which will be removed in future React versions.

Description of the changes

The following changes have been made to the LoadingIndicator component:

  • Removed the defaultProps object from the LoadingIndicator component.
  • Updated LoadingIndicator component to use default parameter values instead.
  • Updated test snapshots

How was this change tested?

  • Default tests provided for the LoadingIndicator component was used to ensure it renders exactly as before the changes were made

Checklist

@Ghaby-X Ghaby-X requested a review from a team as a code owner September 28, 2024 18:27
@Ghaby-X Ghaby-X requested review from pavolloffay and removed request for a team September 28, 2024 18:27
@Ghaby-X Ghaby-X force-pushed the refactor/update-LoadingIndicator branch from 12511fa to b620846 Compare September 28, 2024 18:29
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Nov 10, 2024
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (902ee7d) to head (969ef59).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2460      +/-   ##
==========================================
- Coverage   96.61%   96.61%   -0.01%     
==========================================
  Files         254      254              
  Lines        7679     7677       -2     
  Branches     1995     1931      -64     
==========================================
- Hits         7419     7417       -2     
  Misses        260      260              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants