Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update history package and fix failing test cases #2370

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DhairyaMajmudar
Copy link

@DhairyaMajmudar DhairyaMajmudar commented Jul 5, 2024

Which problem is this PR solving?

Updating the history package

Replaces #1640

Description of the changes

  1. Updated yarn.lock
  2. Updated package.json
  3. And configure-store.test.js

How was this change tested?

By running the command yarn test previously 3 tests were failing due to updation of package while inspecting the failures 1 got fixed by changing import statement but the rest two were falling due to deprecated history.length

Below is the ss of failing tests

image

Upon checking open issues in core repo. got these:

remix-run/history#811
remix-run/history#960

Checklist

@DhairyaMajmudar DhairyaMajmudar requested a review from a team as a code owner July 5, 2024 07:09
@DhairyaMajmudar DhairyaMajmudar requested review from jkowall and removed request for a team July 5, 2024 07:09
@DhairyaMajmudar
Copy link
Author

cc: @yurishkuro

@yurishkuro
Copy link
Member

#1640 (comment)

Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Dhairya Majmudar <[email protected]>
@DhairyaMajmudar
Copy link
Author

Seems like lint checks are failing due to import { LocationDescriptor } from 'history'; which is now deprecated. In their v5 docs, there's not any mention for an alternative for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants