Increase tracklist.add batchSize #982
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a playlist with over 8,000 local tracks in it. Iris took just over 2 hours to add this playlist to the queue.
I have over playlists of 500 tracks which only took a few seconds.
Seems the reason it's taking so long is because Iris is pushing only 5 tracks at a time. I understand there's efficiency reasons for this, but
mpc clear ; mpc load ... ; mpc play
took only <3 seconds with the same 8,000+ track playlist.I've done some testing with an effectively infinite batchSize and had no problems at all, and was considering adding an extra zero to the batchSize in this commit to bump it up to 10,000, but figured there might be a real reason for this batching that should be discussed before going that far.
I'm not sure what specific symptoms I can test for "locks the Mopidy server", but this 1,000 batchSize let me add this 8,000 track playlist in ~30s.
Increasing it to 9,000 let me add this playlist in ~5s