Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(callouts): properly transclude blockRefs inside callouts #988

Closed

Conversation

saberzero1
Copy link
Collaborator

closes #967

Proposal:

When transcluding a blockref (![[somePage#^123456]]), check for callouts inside the transcluded file. If the transcluded file contains callouts, check every callout for a blockRef matching the current blockRef.

  • if a match is found => transclude the entire callout.
  • if there is no match => use previous behavior.

@jackyzha0 can you give me some feedback on the direction of the implementation?

@saberzero1 saberzero1 changed the title fix(callouts): fix(callouts): properly transclude blockRefs inside callouts Mar 11, 2024
@saberzero1 saberzero1 marked this pull request as ready for review March 12, 2024 21:59
@saberzero1
Copy link
Collaborator Author

Testing set:

index.md

![[transclude_1#^2emjcu]]

![[transclude_1#^m9oxui]]

![[transclude_1#^fdxers]]

transclude_1.md

> [!NOTE] Title
> - 1231231 ^2emjcu

> [!NOTE] list
> - 1
> - 2
> - 3
>  ^m9oxui

> [!NOTE] t1
> in t1
> > [!NOTE] t2
> > in t2 ^fdxers

@aarnphm
Copy link
Collaborator

aarnphm commented Dec 3, 2024

Let's include this in your markdown PR #1496

@aarnphm aarnphm closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transcluding nest callouts doesn't work
2 participants