perf: reduce bundle size (closes #1607) #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Pham <[email protected]>
aarnphm
changed the title
Deploying quartz with
|
| Latest commit: |
c770732
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://68c88325.quartz-1h4.pages.dev |
| Branch Preview URL: | https://perf-reduce-mermaid-build-si.quartz-1h4.pages.dev |
Signed-off-by: Aaron Pham <[email protected]>
jackyzha0
reviewed
Dec 29, 2024
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
aarnphm
commented
Jan 1, 2025
Signed-off-by: Aaron Pham <[email protected]>
jackyzha0
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first step in reducing bundle size. This means we are ablating mermaid from each generated HTML and only include it in postscript.js
Next step: to conditionally add mermaid if vault contains any mermaid graph.
In this case, if a vault doesn't use mermaid graph, we can then not include mermaid at all.
Signed-off-by: Aaron Pham [email protected]