Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tags): Allow separating page tags from frontmatter tags #1672

Open
wants to merge 1 commit into
base: v4
Choose a base branch
from

Conversation

necauqua
Copy link
Contributor

@necauqua necauqua commented Dec 24, 2024

I feel like tags in note content are just links to the tag page, and shouldn't mark the page with that tag.

Also the way it was done - adding content tags to frontmatter - interferes with my WIP page properties component, I want to only show "explicitly put in the frontmatter" tags.
(I made the frontmatter transformer add a frontmatterRaw copy to the file data to avoid this and a few other issues, so this no longer applies.)

Added an option to have those "outgoing" tags that don't tag the page, yet get a tag page generated (so that the popover is not 404 if there are no pages with this tag).

parseTags: true

image

parseTags: "link-only"

image

@necauqua necauqua force-pushed the separate-outgoing-tags branch 3 times, most recently from 27d93a4 to 0d986a7 Compare January 4, 2025 17:52
I feel like tags in note content are just links to the tag page, and
shouldn't mark the page with that tag.

Also the way it was done - adding content tags to frontmatter -
interferes with my WIP page properties component, I want to only show
"explicitly put in the frontmatter" tags.

Added an option to have those "outgoing" tags that don't tag the page,
yet get a tag page generated (so that the popover is not 404 if there
are no pages with this tag).
@necauqua necauqua force-pushed the separate-outgoing-tags branch from 0d986a7 to 7e71676 Compare January 4, 2025 18:41
@necauqua
Copy link
Contributor Author

necauqua commented Jan 4, 2025

I realised that I don't really need this as I can just do wikilinks (so [[tag]] instead of #tag) in my content, which works even better in Obsidian.

But I still think this is a good option to have.

Amended a tiny fix to not slugify tag text in the generated links - again, something that will be an issue with lowercase slugs. eh will move to a separate PR, also it turned out a bit bigger than a oneline fix lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant