refactor(zhihu): simplify question evaluate to follow pixivFetch pattern#754
Merged
refactor(zhihu): simplify question evaluate to follow pixivFetch pattern#754
Conversation
Move data processing (HTML stripping, answer mapping) from browser-side evaluate to Node-side, keeping the evaluate minimal: just fetch + status check. Uses __httpError sentinel consistent with pixivFetch convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__httpErrorsentinel convention consistent withpixivFetch(src/clis/pixiv/utils.ts)Why
PR #732 fixed the runtime issue correctly but left 10 lines of logic inside the evaluate string (strip function, try/catch, data mapping). The established pattern in this codebase (see
pixivFetch) keeps evaluate minimal and does all processing in Node where it's more readable, testable, and debuggable.Test plan