feat(browser): auto-detect chromium browsers for bridge#743
Open
umnooob wants to merge 6 commits intojackwener:mainfrom
Open
feat(browser): auto-detect chromium browsers for bridge#743umnooob wants to merge 6 commits intojackwener:mainfrom
umnooob wants to merge 6 commits intojackwener:mainfrom
Conversation
- Reuse discoverAppPath/detectProcess from launcher.ts instead of duplicating - Add spawn error handler to prevent unhandled ENOENT crashes - Simplify _tryLaunchBrowsers: remove _tryCandidateGroup indirection - Extract BROWSER_DEFS constant for clarity
…s conflict - Restore per-browser time budget to fairly distribute timeout across candidates - Replace _lastDetectedBrowsers/_lastTriedBrowsers with LaunchResult return value - Remove 'chrome.exe' from Chromium processNames to avoid Windows conflict with Chrome - Remove redundant env spread in spawn options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #742
Summary
This PR improves Browser Bridge connection behavior in two steps:
Supported browser family order remains fixed:
Connection attempts now work like this:
It also lets
opencli doctorshow the browser inferred from this run when connectivity is established duringthe current attempt.
Included commits
9f9705cfeat(browser): auto-detect chromium browsers for bridgef2af57bfeat(browser): prefer running browsers for bridgeWhat changed
Browser auto-detect
Running-browser preference
Doctor inference
doctorreports the inferred browser for that rundoctordoes not pretend to know the browserMessaging
Files changed
src/browser/candidates.tssrc/browser/candidates.test.tssrc/browser/bridge.tssrc/browser.test.tssrc/doctor.tssrc/doctor.test.tssrc/execution.tssrc/doctor.tsscripts/postinstall.jsNotes
Type of Change
Checklist
Screenshots / Output