fix: add prepare script so source installs trigger build#729
Merged
Conversation
npm install from git (e.g. npm install github:jackwener/opencli) skips prepublishOnly, so dist/ is never generated. The prepare hook runs on git-based installs; the [ -d src ] guard skips it for registry installs.
.gitignore had conflicting rules: line 3 tried to un-ignore extension/dist/ but line 26 re-ignored it. Remove the later rule so the built extension JS is tracked in git — users can load the extension directly after clone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm install github:jackwener/opencli或npm install -g .）时prepublishOnly不会运行，导致dist/不存在preparescript，从 git 安装时自动触发npm run build[ -d src ]判断确保从 npm registry 安装时（没有 src/）不会报错Test plan
npm install -g .验证 prepare 触发 buildnpm install github:jackwener/opencli验证远程源码安装