refactor: adopt CliError in additional adapters#378
Closed
Conversation
Replace raw Error throws with appropriate CliError subclasses in: - antigravity (5 files): SelectorError for UI elements - barchart (1 file): AuthRequiredError for login issues - boss (7 files): AuthRequiredError, CommandExecutionError, SelectorError, EmptyResultError - chaoxing (1 file): CommandExecutionError - coupang (2 files): ArgumentError, CommandExecutionError - discord-app (2 files): SelectorError for UI elements - douban (1 file): EmptyResultError - doubao-app (2 files): CommandExecutionError, SelectorError - notion (1 file): SelectorError for UI elements - sinablog (1 file): CommandExecutionError - xiaohongshu (7 files): AuthRequiredError, CommandExecutionError, EmptyResultError, ArgumentError, TimeoutError Based on work from @coding-claude-opus (PR #374), excludes social adapters already covered by PR #375.
- reddit/saved.ts, reddit/upvoted.ts: Use CommandExecutionError for API errors - chaoxing/assignments.ts: Use EmptyResultError for course not found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue CliError adoption for adapters not covered in PR #375.
Changes
31 files changed
Test