refactor: make daemon persistent, remove idle timeout#913
Merged
Conversation
- Remove IdleManager and 4-hour idle auto-exit - Daemon now stays alive until explicit shutdown or uninstall - Add preuninstall hook for best-effort daemon cleanup on npm uninstall - Update docs to reflect persistent daemon model
- Remove `daemon status` and `daemon restart` CLI commands (doctor covers diagnostics) - Remove `lastCliRequestTime` tracking (no longer needed without idle timeout) - Keep only `daemon stop` as the explicit shutdown command
Prevents npm uninstall from hanging if the daemon port accepts connections but never responds.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IdleManagerand 4-hour idle auto-exit — daemon is now persistentpreuninstallhook for best-effort daemon cleanup onnpm uninstallChanges
src/idle-manager.tsandsrc/daemon.test.ts(IdleManager tests)DEFAULT_DAEMON_IDLE_TIMEOUTfrom constantssrc/daemon.ts— replace IdleManager with simplelastCliRequestTimetracking for/statusendpointpreuninstallscript topackage.jsonthat sends POST /shutdown to daemonContext
Discussion in thread #OpenCLI:1bd0da0e — user decided daemon should be persistent (users don't care about the memory), idle timeout is unnecessary overhead.