pretext to start a discussion ;) #15
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title say, I don't expect this PR to be merged as it is. I made some changes in many parts for many reasons, I could propose things one by one of course.
I am motivated to make some work on this lib, I use it myself 3 times in my softs (Patchance + RaySession x 2).
I would be happy to have your opinion about the following points:
I was wondering why there were callbacks CFUNCTYPE saved as global (_thread_init_callback, _shutdown_callback ... example line 699/700) in the API functions. I discovered that it was just a way to prevent python cleaner to remove these objects. In addition to the fact that I find it quite dirty, I see the impossibility to get 2 jack clients with same callback working correctly (the 2nd callback will erase the 1st, not tested but I am pretty sure). That's why I simply add theses objects to a list (_used_callbacks).