fix(pgxpool): handle context cancellation race during acquire to prevent deadlocks - #8
Open
parastejpal987-cmyk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a severe connection pool drain (deadlock) that occurs under extreme concurrency when a waiting
Acquire(ctx)call has its context canceled at the exact millisecond a connection is handed off to it.Previously, if
p.p.Acquire(ctx)returned successfully but the caller's context had just been canceled, the connection was returned to the caller along with the context error, effectively leaking the connection since the caller assumes failure. Over time, these phantom connections drain the pool capacity to zero, resulting in a permanent deadlock for all futureAcquirecalls.Fix
Added a safety check in
pgxpool/pool.goimmediately after acquiring the underlying pool connection. Ifctx.Err() != nilat that exact moment, the connection is safely released back into the pool viares.Release().Related Issue
Resolves the pgxpool deadlock/context cancellation bug.