Feature/issue 611 #660
Draft
Feature/issue 611 #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite the cleanup. NBI is no more.
Uses NBPackage and heavily leverages Bash scripts. I'm not an expert on either one so there might be some issues there.
Tagging as per usual. Builds ZIP, DEB (as opposed to sh -installer), Windows EXE and MacOS PKG files. MacOS PKGs differ only by bundling the correct JDK. JDKs are automatically downloaded as previously.
After this I suppose it gets a bit easier as we don't need to copy any changed NBI files. This should work regardless of NB version. A bit complicated to understand, hopefully doesn't require so much maintenance...
Current TODO:
Closes #611