Fix misuse of read and skipBytes #2557
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2555 across the entire engine.
This PR fixes the implementation of
LittleEndien.readFully()
and introduces two new utility methods inByteUtils
:readFully
skipFully
Both ensure that the requested number of bytes are reliably read or skipped, even if the underlying stream does not return the full amount in a single call.
The changes are not yet fully tested, but they are part of the codebase I am actively working with. Additional testing and verification from others would be greatly appreciated.