Skip to content

jme3-examples: TestReverb code cleanup #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

capdevon
Copy link
Contributor

@capdevon capdevon commented May 3, 2025

Refactored the TestReverb example code for improved clarity. This commit restructures the demo to explicitly highlight its individual components, making it easier to understand the flow and functionality.

Refactored the TestReverb example code for improved clarity. This commit restructures the demo to explicitly highlight its individual components, making it easier to understand the flow and functionality.
Copy link
Contributor

@codex128 codex128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@capdevon capdevon changed the title Update TestReverb: code cleanup jme3-examples: TestReverb code cleanup May 3, 2025
@yaRnMcDonuts yaRnMcDonuts added this to the v3.9.0 milestone May 6, 2025
Added more test Environments and some options to enable/disable the Reverb Filter
@capdevon
Copy link
Contributor Author

capdevon commented May 6, 2025

@yaRnMcDonuts Wait a bit before merge this PR, I am using it to test the combined effects of the Environment and Reverb Filters. I will let you know when it is ready ;)

Edit:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants