-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
jme3-examples: TestReverb code cleanup #2419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yaRnMcDonuts
merged 9 commits into
jMonkeyEngine:master
from
capdevon:capdevon-TestReverb
May 10, 2025
Merged
jme3-examples: TestReverb code cleanup #2419
yaRnMcDonuts
merged 9 commits into
jMonkeyEngine:master
from
capdevon:capdevon-TestReverb
May 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the TestReverb example code for improved clarity. This commit restructures the demo to explicitly highlight its individual components, making it easier to understand the flow and functionality.
codex128
approved these changes
May 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Added more test Environments and some options to enable/disable the Reverb Filter
@yaRnMcDonuts Wait a bit before merge this PR, I am using it to test the combined effects of the Environment and Reverb Filters. I will let you know when it is ready ;) |
@yaRnMcDonuts, the PR is now complete and ready to be merged or reviewed ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
TestReverb
example code for improved clarity. This commit restructures the demo to explicitly highlight its individual components, making it easier to understand the flow and functionality.