-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add toggleable fb mipmaps generation
- Loading branch information
1 parent
5656fe4
commit 8ab3d24
Showing
2 changed files
with
25 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,6 +84,7 @@ public class FrameBuffer extends NativeObject { | |
private RenderBuffer depthBuf = null; | ||
private int colorBufIndex = 0; | ||
private boolean srgb; | ||
private Boolean mipsGenerationHint = null; | ||
|
||
/** | ||
* <code>RenderBuffer</code> represents either a texture or a | ||
|
@@ -842,4 +843,17 @@ public void setSrgb(boolean srgb) { | |
public boolean isSrgb() { | ||
return srgb; | ||
} | ||
|
||
|
||
/** | ||
* Hints the renderer to generate mipmaps for this framebuffer if necessary | ||
* @param v true to enable, null to use the default value for the renderer (default to null) | ||
*/ | ||
public void setMipMapsGenerationHint(Boolean v) { | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
stephengold
Member
|
||
mipsGenerationHint = v; | ||
} | ||
|
||
public Boolean getMipMapsGenerationHint() { | ||
return mipsGenerationHint; | ||
} | ||
} |
Hi Guys, just a little tip. To facilitate the reading and maintenance of the code, we could rename the getter / setter methods according to the variable name? get/set MipMapsGenerationHint -> get/set MipsGenerationHint ? Or rename the variable name mipsGenerationHint -> mipMapsGenerationHint?