fix: restore per-note header visibility state on note switch#85
Merged
fix: restore per-note header visibility state on note switch#85
Conversation
Previously, headerHidden was a single global boolean that was always reset to visible when switching notes. This caused the header open/close state to not be restored when returning to a note where the header was hidden. Now headerHiddenMap stores state per note (Record<noteId, boolean>), matching the pattern used by scroll/cursor position memory. Also adds scroll-to-top fallback when no saved scroll position exists for a note, fixing content appearing cut off when opening new notes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
headerHiddenfrom a single global boolean to a per-noteRecord<string, boolean>map (headerHiddenMap), matching the pattern used by scroll/cursor position memorynoteIdparameter touseScrollDirectionhook with automatic state restoration viauseEffectresetHeader()call fromselectNote()in favor of reactive noteId-based restorationheaderHiddenboolean key to the new map formatmapLoadedRefguard to prevent race condition between async store load and noteId change effectuseBlockScrollMemorywhen no saved scroll position exists for a note, fixing content appearing cut off when opening new notes from a hidden-header noteTest plan
headerHiddenboolean is migrated and cleaned up on first launch🤖 Generated with Claude Code