Skip to content

fix(editor): prevent padding click handler from closing toolbar on button clicks #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j4rviscmd merged 1 commit into from
Mar 29, 2026
Merged

fix(editor): prevent padding click handler from closing toolbar on button clicks #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/features/editor/ui/Editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,18 +567,18 @@ export const Editor = forwardRef<EditorHandle, EditorProps>(function Editor(
* 1. **Locked mode** – when the editor is read-only (`locked` is `true`),
* the callback is a no-op so that clicking the padding area does not
* steal focus or move the cursor.
* 2. **Inside `.bn-editor`** – if the click originated inside the
* contenteditable region (including any descendant elements), the
* callback returns early and lets the default browser behaviour handle
* focus normally.
* 2. **Inside `.bn-container`** – if the click originated inside the
* BlockNote container (including the editor, toolbars, menus, and other
* UI overlays), the callback returns early and lets the default browser
* behaviour handle focus normally.
*
* @param e - The React mouse event from the wrapper `<div>`.
*/
const handleWrapperClick = useCallback(
(e: React.MouseEvent<HTMLDivElement>) => {
if (locked) return
const target = e.target as HTMLElement
if (target.closest('.bn-editor')) return
if (target.closest('.bn-container')) return
if (target.closest('[role="dialog"]')) return

const lastBlock = editor.document[editor.document.length - 1]
Expand Down
Loading