fix(editor): replace broken edit link popover with custom dialog#118
Merged
fix(editor): replace broken edit link popover with custom dialog#118
Conversation
Replace BlockNote's nested Radix Popover (EditLinkButton) with a custom shadcn Dialog using the "Lifted Dialog" pattern. This fixes the dialog failing to appear and focus jumping to the bottom of the document. Changes: - Add EditLinkButton.tsx: toolbar button with React Context for callback threading through LinkToolbarController - Add EditLinkDialog.tsx: shadcn Dialog with URL/text inputs, IME composition guard, and BlockNote editLink() API integration - Modify useLinkClickHandler.ts: intercept all link clicks to prevent TipTap's openOnClick handler; only Cmd/Ctrl+Click opens in browser - Add cursor UX: text cursor on links by default, pointer when Cmd/Ctrl is held (matching VS Code/Notion behavior) - Fix handleWrapperClick stealing focus from dialogs by adding role="dialog" guard Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace BlockNote's nested Radix Popover (
EditLinkButton) with a custom shadcn Dialog using the "Lifted Dialog" pattern. This fixes the Edit Link dialog failing to appear and focus jumping to the bottom of the document.Also changes link click behavior to Cmd/Ctrl+Click (matching VS Code/Notion) and adds visual cursor feedback when modifier keys are held.
Related Issue
No existing issue — discovered during manual testing of the link toolbar.
Type of Change
Breaking Changes
None.
Test
npm run tauri devChecklist