Skip to content

fix(editor): restore click-to-focus on editor padding area#109

Merged
j4rviscmd merged 2 commits intomainfrom
fix/focus-click-fix
Mar 28, 2026
Merged

fix(editor): restore click-to-focus on editor padding area#109
j4rviscmd merged 2 commits intomainfrom
fix/focus-click-fix

Conversation

@j4rviscmd
Copy link
Copy Markdown
Owner

Summary

Restore the handleWrapperClick callback that was accidentally removed in commit 3e11cb6 (checklist split fix). This re-enables the behaviour where clicking in the pb-[60vh] padding zone below the editor content focuses the editor at the end of the last block.

Also adds a locked mode guard so the handler is a no-op when the note is in read-only mode.

Related Issue

N/A — Regression fix (feature was added in 9c3ea37, removed in 3e11cb6)

Type of Change

  • ✨ New feature
  • 💥 Breaking change
  • 🐛 Bug fix
  • 📝 Documentation
  • ♻️ Refactoring
  • 🔧 Chore

Breaking Changes

None

Test

  • Run npm run dev
  • Open a note with content
  • Click in the empty area below the note content (the padding area)
  • Verify the cursor moves to the end of the last block and the editor gains focus
  • Lock a note and verify clicking the padding area does nothing

Checklist

  • Code follows clean architecture (proper separation of concerns)
  • Code is simple and concise (no unnecessary complexity)
  • Comments are sufficient for non-obvious logic
  • No sensitive information included (credentials, secrets, personal data)
  • Conventional Commits format followed in commit messages
  • Tests added/updated (or N/A for docs/chore)

j4rviscmd and others added 2 commits March 28, 2026 22:09
The handleWrapperClick callback was accidentally removed in commit
3e11cb6 while adding the checklistSplitFixExtension. This restores
the behaviour where clicking in the pb-[60vh] padding zone below the
editor content focuses the editor at the end of the last block.

Added a locked-mode guard so the handler is a no-op when the note
is in read-only mode.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@j4rviscmd j4rviscmd added the bug Something isn't working label Mar 28, 2026
@j4rviscmd j4rviscmd merged commit 6cccb9a into main Mar 28, 2026
2 checks passed
@j4rviscmd j4rviscmd deleted the fix/focus-click-fix branch March 28, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant