fix(core): Gracefully handle invalid date format in preferences - #51
Open
sentry[bot] wants to merge 1 commit into
Open
fix(core): Gracefully handle invalid date format in preferences#51sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #51 +/- ##
==========================================
- Coverage 92.65% 92.63% -0.03%
==========================================
Files 100 100
Lines 8250 8253 +3
Branches 705 705
==========================================
+ Hits 7644 7645 +1
- Misses 460 462 +2
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue NURSE-SCHEDULING-1W where an invalid date string, such as 'Freeday_' (a typo of a date group ID), provided in a preference would cause a
ValueErrorin_parse_single_date.Previously, this
ValueErrorpropagated unhandled throughscheduler.scheduletoOptimizationRunner.run, leading to an unexpected job crash.The fix involves wrapping the
scheduler.schedulecall withinOptimizationRunner.runincore/nurse_scheduling/server/jobs/runner.pywith atry/except ValueErrorblock. If aValueErroroccurs during scheduling, it is now caught, and aJobFailurewithcode="invalid_model"and the original error message is returned. This ensures that the optimization job fails gracefully with a clear, user-facing error message instead of crashing.Fixes NURSE-SCHEDULING-1W