fix(core/loader): Handle non-mapping YAML input gracefully - #43
Open
sentry[bot] wants to merge 1 commit into
Open
fix(core/loader): Handle non-mapping YAML input gracefully#43sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #43 +/- ##
=======================================
Coverage 91.57% 91.57%
=======================================
Files 77 77
Lines 5220 5220
Branches 704 704
=======================================
Hits 4780 4780
Misses 293 293
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
NurseSchedulingData(**data)withNurseSchedulingData.model_validate(data)incore/nurse_scheduling/loader.py.This change addresses a
TypeErrorthat occurred when a user uploaded a YAML file whose root element was not a mapping (e.g., a scalar string). The previous implementation would attempt to unpack a string using**data, leading to aTypeError.By using Pydantic's
model_validate(data), the system now correctly handles non-mapping inputs by raising aValidationError, providing a more robust and user-friendly error message instead of a low-level PythonTypeError.Fixes NURSE-SCHEDULING-5